bda5bc6c0e
**Problem:** - player-ownership.ts imported drizzle-orm and @/db at top level - When RoomMemoryPairsProvider imported client-safe utilities, Webpack bundled ALL imports including database code - This caused hydration error: "The 'original' argument must be of type Function" - Node.js util.promisify was being called in browser context **Solution:** 1. Created player-ownership.client.ts with ONLY client-safe utilities - No database imports - Safe to import from 'use client' components - Contains: buildPlayerOwnershipFromRoomData(), buildPlayerMetadata(), helper functions 2. Updated player-ownership.ts to re-export client utilities and add server-only functions - Re-exports everything from .client.ts - Adds buildPlayerOwnershipMap() (async, database-backed) - Safe to import from server components/API routes 3. Updated RoomMemoryPairsProvider to import from .client.ts **Result:** - No more hydration errors on /arcade/room - Client bundle doesn't include database code - Server code can still use both client and server utilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
80 lines
2.3 KiB
Markdown
80 lines
2.3 KiB
Markdown
# Testing
|
|
|
|
This directory contains automated tests for the Soroban flashcard generator.
|
|
|
|
## Test Structure
|
|
|
|
- `test_config.py` - Configuration loading and parsing tests
|
|
- `test_generation.py` - Core generation logic tests
|
|
- `test_visual.py` - Visual regression tests using image comparison
|
|
- `conftest.py` - Pytest fixtures and configuration
|
|
- `references/` - Reference images for visual regression tests
|
|
|
|
## Running Tests
|
|
|
|
### Quick Start
|
|
|
|
```bash
|
|
make pytest-fast # Run unit tests (fast)
|
|
make pytest-visual # Run visual regression tests
|
|
make pytest # Run all tests
|
|
make pytest-cov # Run with coverage report
|
|
```
|
|
|
|
### Direct pytest usage
|
|
|
|
```bash
|
|
# All tests
|
|
python3 -m pytest tests/ -v
|
|
|
|
# Skip slow tests
|
|
python3 -m pytest tests/ -v -m "not slow"
|
|
|
|
# Visual tests only
|
|
python3 -m pytest tests/test_visual.py -v
|
|
|
|
# With coverage
|
|
python3 -m pytest tests/ -v --cov=src
|
|
```
|
|
|
|
## Visual Testing
|
|
|
|
The visual tests generate flashcard images and compare them against reference images using perceptual hashing. This catches visual regressions while allowing for minor differences.
|
|
|
|
### Updating References
|
|
|
|
When you make intentional visual changes, manually delete the old reference images in `tests/references/` and run the visual tests. They will automatically create new reference images on first run.
|
|
|
|
### How Visual Tests Work
|
|
|
|
1. Generate test images (PNG format, small size for speed)
|
|
2. Compare against reference images using `imagehash` library
|
|
3. Allow small differences (hash distance < 5) for anti-aliasing variations
|
|
4. Fail if images differ significantly, indicating a regression
|
|
|
|
### Test Philosophy
|
|
|
|
- **Fast unit tests** for logic and configuration
|
|
- **Visual regression tests** for output verification
|
|
- **Integration tests** marked as `@pytest.mark.slow`
|
|
- **Meaningful failures** with clear error messages
|
|
- **Easy maintenance** when the app evolves
|
|
|
|
## Adding Tests
|
|
|
|
When adding features:
|
|
|
|
1. Add unit tests in relevant `test_*.py` file
|
|
2. Add visual tests if output changes
|
|
3. Update references if visual changes are intentional
|
|
4. Use appropriate markers (`@pytest.mark.slow`, etc.)
|
|
|
|
## CI Integration
|
|
|
|
Tests are designed to run in CI environments:
|
|
|
|
- Skip tests requiring typst if not installed
|
|
- Use smaller images and lower DPI for speed
|
|
- Store reference images in version control
|
|
- Clear pass/fail criteria
|