chore(release): 3.17.3 [skip ci]

## [3.17.3](https://github.com/antialias/soroban-abacus-flashcards/compare/v3.17.2...v3.17.3) (2025-10-15) ### Bug Fixes * **arcade:** preserve gameConfig when switching games ([2273c71](2273c71a87)) ### Code Refactoring * remove verbose console logging for cleaner debugging ([9cb5fdd](9cb5fdd2fa))
fix(arcade): preserve gameConfig when switching games
2025-10-15 15:13:35 +00:00 · 2025-10-15 10:12:33 -05:00 · 2025-10-15 10:04:24 -05:00
5 changed files with 43 additions and 82 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,15 @@
+## [3.17.3](https://github.com/antialias/soroban-abacus-flashcards/compare/v3.17.2...v3.17.3) (2025-10-15)
+
+
+### Bug Fixes
+
+* **arcade:** preserve gameConfig when switching games ([2273c71](https://github.com/antialias/soroban-abacus-flashcards/commit/2273c71a872a5122d0b2023835fe30640106048e))
+
+
+### Code Refactoring
+
+* remove verbose console logging for cleaner debugging ([9cb5fdd](https://github.com/antialias/soroban-abacus-flashcards/commit/9cb5fdd2fa43560adc32dd052f47a7b06b2c5b69))
+
 ## [3.17.2](https://github.com/antialias/soroban-abacus-flashcards/compare/v3.17.1...v3.17.2) (2025-10-15)


--- a/apps/web/src/app/arcade/memory-quiz/context/RoomMemoryQuizProvider.tsx
+++ b/apps/web/src/app/arcade/memory-quiz/context/RoomMemoryQuizProvider.tsx
@@ -55,35 +55,21 @@ function applyMoveOptimistically(state: SorobanQuizState, move: GameMove): Sorob
      const activePlayers = move.data.activePlayers || []
      const playerMetadata = move.data.playerMetadata || {}

-      console.log('🎯 [START_QUIZ] Initializing player scores:', {
-        activePlayers,
-        playerMetadata,
-      })
-
      // Extract unique userIds from playerMetadata
      const uniqueUserIds = new Set<string>()
      for (const playerId of activePlayers) {
        const metadata = playerMetadata[playerId]
-        console.log('🎯 [START_QUIZ] Processing player:', {
-          playerId,
-          metadata,
-          hasUserId: !!metadata?.userId,
-        })
        if (metadata?.userId) {
          uniqueUserIds.add(metadata.userId)
        }
      }

-      console.log('🎯 [START_QUIZ] Unique userIds found:', Array.from(uniqueUserIds))
-
      // Initialize scores for each userId
      const playerScores = Array.from(uniqueUserIds).reduce((acc: any, userId: string) => {
        acc[userId] = { correct: 0, incorrect: 0 }
        return acc
      }, {})

-      console.log('🎯 [START_QUIZ] Initialized playerScores:', playerScores)
-
      return {
        ...state,
        quizCards,
@@ -122,12 +108,6 @@ function applyMoveOptimistically(state: SorobanQuizState, move: GameMove): Sorob
      const foundNumbers = state.foundNumbers || []
      const numberFoundBy = state.numberFoundBy || {}

-      console.log('✅ [ACCEPT_NUMBER] Before update:', {
-        moveUserId: move.userId,
-        currentPlayerScores: playerScores,
-        number: move.data.number,
-      })
-
      const newPlayerScores = { ...playerScores }
      const newNumberFoundBy = { ...numberFoundBy }

@@ -139,15 +119,6 @@ function applyMoveOptimistically(state: SorobanQuizState, move: GameMove): Sorob
        }
        // Track who found this number
        newNumberFoundBy[move.data.number] = move.userId
-
-        console.log('✅ [ACCEPT_NUMBER] After update:', {
-          userId: move.userId,
-          newScore: newPlayerScores[move.userId],
-          allScores: newPlayerScores,
-          numberFoundBy: move.data.number,
-        })
-      } else {
-        console.warn('⚠️ [ACCEPT_NUMBER] No userId in move!')
      }
      return {
        ...state,
@@ -162,11 +133,6 @@ function applyMoveOptimistically(state: SorobanQuizState, move: GameMove): Sorob
      // Defensive check: ensure state properties exist
      const playerScores = state.playerScores || {}

-      console.log('❌ [REJECT_NUMBER] Before update:', {
-        moveUserId: move.userId,
-        currentPlayerScores: playerScores,
-      })
-
      const newPlayerScores = { ...playerScores }
      if (move.userId) {
        const currentScore = newPlayerScores[move.userId] || { correct: 0, incorrect: 0 }
@@ -174,13 +140,6 @@ function applyMoveOptimistically(state: SorobanQuizState, move: GameMove): Sorob
          ...currentScore,
          incorrect: currentScore.incorrect + 1,
        }
-        console.log('❌ [REJECT_NUMBER] After update:', {
-          userId: move.userId,
-          newScore: newPlayerScores[move.userId],
-          allScores: newPlayerScores,
-        })
-      } else {
-        console.warn('⚠️ [REJECT_NUMBER] No userId in move!')
      }
      return {
        ...state,
@@ -251,15 +210,23 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {
  // Settings are scoped by game name to preserve settings when switching games
  const mergedInitialState = useMemo(() => {
    const gameConfig = roomData?.gameConfig as Record<string, any> | null | undefined
-    if (!gameConfig) return initialState
+    console.log('[RoomMemoryQuizProvider] Initializing - gameConfig:', gameConfig)
+
+    if (!gameConfig) {
+      console.log('[RoomMemoryQuizProvider] No gameConfig, using initialState')
+      return initialState
+    }

    // Get settings for this specific game (memory-quiz)
    const savedConfig = gameConfig['memory-quiz'] as Record<string, any> | null | undefined
-    if (!savedConfig) return initialState
+    console.log('[RoomMemoryQuizProvider] Loading saved config for memory-quiz:', savedConfig)

-    console.log('[RoomMemoryQuizProvider] Loading saved game config for memory-quiz:', savedConfig)
+    if (!savedConfig) {
+      console.log('[RoomMemoryQuizProvider] No saved config for memory-quiz, using initialState')
+      return initialState
+    }

-    return {
+    const merged = {
      ...initialState,
      // Restore settings from saved config
      selectedCount: savedConfig.selectedCount ?? initialState.selectedCount,
@@ -267,6 +234,14 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {
      selectedDifficulty: savedConfig.selectedDifficulty ?? initialState.selectedDifficulty,
      playMode: savedConfig.playMode ?? initialState.playMode,
    }
+    console.log('[RoomMemoryQuizProvider] Merged state:', {
+      selectedCount: merged.selectedCount,
+      displayTime: merged.displayTime,
+      selectedDifficulty: merged.selectedDifficulty,
+      playMode: merged.playMode,
+    })
+
+    return merged
  }, [roomData?.gameConfig])

  // Arcade session integration WITH room sync
@@ -310,19 +285,8 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {

  // Build player metadata from room data and player map
  const buildPlayerMetadata = useCallback(() => {
-    console.log('🔍 [buildPlayerMetadata] Starting:', {
-      roomData: roomData?.id,
-      activePlayers,
-      viewerId,
-      playersMapSize: players.size,
-    })
-
    const playerOwnership = buildPlayerOwnershipFromRoomData(roomData)
-    console.log('🔍 [buildPlayerMetadata] Player ownership:', playerOwnership)
-
    const metadata = buildPlayerMetadataUtil(activePlayers, playerOwnership, players, viewerId)
-    console.log('🔍 [buildPlayerMetadata] Built metadata:', metadata)
-
    return metadata
  }, [activePlayers, players, roomData, viewerId])

@@ -336,13 +300,6 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {
      // Build player metadata for multiplayer
      const playerMetadata = buildPlayerMetadata()

-      console.log('🚀 [startQuiz] Sending START_QUIZ move:', {
-        viewerId,
-        activePlayers,
-        playerMetadata,
-        numbers,
-      })
-
      sendMove({
        type: 'START_QUIZ',
        playerId: TEAM_MOVE, // Team move - all players act together
@@ -381,11 +338,6 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {
      // Clear local input immediately
      setLocalCurrentInput('')

-      console.log('🚀 [acceptNumber] Sending ACCEPT_NUMBER move:', {
-        viewerId,
-        number,
-      })
-
      sendMove({
        type: 'ACCEPT_NUMBER',
        playerId: TEAM_MOVE, // Team move - can't identify specific player
@@ -400,10 +352,6 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {
    // Clear local input immediately
    setLocalCurrentInput('')

-    console.log('🚀 [rejectNumber] Sending REJECT_NUMBER move:', {
-      viewerId,
-    })
-
    sendMove({
      type: 'REJECT_NUMBER',
      playerId: TEAM_MOVE, // Team move - can't identify specific player
@@ -438,6 +386,8 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {

  const setConfig = useCallback(
    (field: 'selectedCount' | 'displayTime' | 'selectedDifficulty' | 'playMode', value: any) => {
+      console.log(`[RoomMemoryQuizProvider] setConfig called: ${field} = ${value}`)
+
      sendMove({
        type: 'SET_CONFIG',
        playerId: TEAM_MOVE,
@@ -449,8 +399,11 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {
      // Settings are scoped by game name to preserve settings when switching games
      if (roomData?.id) {
        const currentGameConfig = (roomData.gameConfig as Record<string, any>) || {}
+        console.log('[RoomMemoryQuizProvider] Current gameConfig:', currentGameConfig)
+
        const currentMemoryQuizConfig =
          (currentGameConfig['memory-quiz'] as Record<string, any>) || {}
+        console.log('[RoomMemoryQuizProvider] Current memory-quiz config:', currentMemoryQuizConfig)

        const updatedConfig = {
          ...currentGameConfig,
@@ -459,11 +412,13 @@ export function RoomMemoryQuizProvider({ children }: { children: ReactNode }) {
            [field]: value,
          },
        }
-        console.log('[RoomMemoryQuizProvider] Saving game config for memory-quiz:', updatedConfig)
+        console.log('[RoomMemoryQuizProvider] Saving updated gameConfig:', updatedConfig)
        updateGameConfig({
          roomId: roomData.id,
          gameConfig: updatedConfig,
        })
+      } else {
+        console.warn('[RoomMemoryQuizProvider] No roomData.id, cannot save config')
      }
    },
    [viewerId, sendMove, roomData?.id, roomData?.gameConfig, updateGameConfig]
--- a/apps/web/src/app/arcade/room/page.tsx
+++ b/apps/web/src/app/arcade/room/page.tsx
@@ -111,13 +111,13 @@ export default function RoomPage() {
      console.log('[RoomPage] Calling setRoomGame with:', {
        roomId: roomData.id,
        gameName: internalGameName,
-        gameConfig: {},
+        preservingGameConfig: true,
      })

+      // Don't pass gameConfig - we want to preserve existing settings for all games
      setRoomGame({
        roomId: roomData.id,
        gameName: internalGameName,
-        gameConfig: {},
      })
    }

--- a/apps/web/src/hooks/useRoomData.ts
+++ b/apps/web/src/hooks/useRoomData.ts
@@ -353,7 +353,6 @@ export function useRoomData() {

    // Moderation event handlers
    const handleKickedFromRoom = (data: { roomId: string; kickedBy: string; reason?: string }) => {
-      console.log('[useRoomData] User was kicked from room:', data)
      setModerationEvent({
        type: 'kicked',
        data: {
@@ -367,7 +366,6 @@ export function useRoomData() {
    }

    const handleBannedFromRoom = (data: { roomId: string; bannedBy: string; reason: string }) => {
-      console.log('[useRoomData] User was banned from room:', data)
      setModerationEvent({
        type: 'banned',
        data: {
@@ -391,7 +389,6 @@ export function useRoomData() {
        createdAt: Date
      }
    }) => {
-      console.log('[useRoomData] New report submitted:', data)
      setModerationEvent({
        type: 'report',
        data: {
@@ -416,7 +413,6 @@ export function useRoomData() {
        createdAt: Date
      }
    }) => {
-      console.log('[useRoomData] Room invitation received:', data)
      setModerationEvent({
        type: 'invitation',
        data: {
@@ -439,7 +435,6 @@ export function useRoomData() {
        createdAt: Date
      }
    }) => {
-      console.log('[useRoomData] New join request submitted:', data)
      setModerationEvent({
        type: 'join-request',
        data: {
@@ -496,7 +491,6 @@ export function useRoomData() {
  // Function to notify room members of player updates
  const notifyRoomOfPlayerUpdate = useCallback(() => {
    if (socket && roomData?.id && userId) {
-      console.log('[useRoomData] Notifying room of player update')
      socket.emit('players-updated', { roomId: roomData.id, userId })
    }
  }, [socket, roomData?.id, userId])
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "soroban-monorepo",
-  "version": "3.17.2",
+  "version": "3.17.3",
  "private": true,
  "description": "Beautiful Soroban Flashcard Generator - Monorepo",
  "workspaces": [