Compare commits

..

3 Commits

Author SHA1 Message Date
semantic-release-bot
41d3e08fc6 chore(release): 2.19.1 [skip ci]
## [2.19.1](https://github.com/antialias/soroban-abacus-flashcards/compare/v2.19.0...v2.19.1) (2025-10-10)

### Bug Fixes

* prevent SSR hydration error in /arcade/room page ([cd38f42](cd38f42e9c))

### Code Refactoring

* migrate RoomMemoryPairsProvider to centralized ownership utilities ([10f4288](10f42887a3))
2025-10-10 14:09:22 +00:00
Thomas Hallock
cd38f42e9c fix: prevent SSR hydration error in /arcade/room page
Add mounted check to prevent QueryClientProvider errors during SSR.
React Query hooks cannot run during server-side rendering, so we
gate the hook calls until after the component has mounted on the client.

This fixes the "No QueryClient set" error that was appearing when
navigating to /arcade/room.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-10 09:08:26 -05:00
Thomas Hallock
10f42887a3 refactor: migrate RoomMemoryPairsProvider to centralized ownership utilities
Replace custom buildPlayerMetadata implementation with centralized
player-ownership utilities. This eliminates 33 lines of duplicate code
and ensures consistent player ownership logic across the codebase.

Changes:
- Replace inline playerOwnership map building with buildPlayerOwnershipFromRoomData()
- Use buildPlayerMetadata() from centralized module
- Remove unused useArcadeRedirect import
- Rename local callback to buildPlayerMetadataCallback for clarity

Benefits:
- Single source of truth for player ownership logic
- Reduced code duplication (33 lines eliminated)
- Consistent with session-manager and player-manager implementations
- Better maintainability and testability

Part of Phase 4 of the player ownership centralization plan.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-10 09:00:16 -05:00
4 changed files with 51 additions and 36 deletions

View File

@@ -1,3 +1,15 @@
## [2.19.1](https://github.com/antialias/soroban-abacus-flashcards/compare/v2.19.0...v2.19.1) (2025-10-10)
### Bug Fixes
* prevent SSR hydration error in /arcade/room page ([cd38f42](https://github.com/antialias/soroban-abacus-flashcards/commit/cd38f42e9c90ff8bab28f7a677c1f9307406d013))
### Code Refactoring
* migrate RoomMemoryPairsProvider to centralized ownership utilities ([10f4288](https://github.com/antialias/soroban-abacus-flashcards/commit/10f42887a323a755e2741ee1b927a0bc16eb69fc))
## [2.19.0](https://github.com/antialias/soroban-abacus-flashcards/compare/v2.18.0...v2.19.0) (2025-10-10)

View File

@@ -1,10 +1,13 @@
'use client'
import { type ReactNode, useCallback, useEffect, useMemo } from 'react'
import { useArcadeRedirect } from '@/hooks/useArcadeRedirect'
import { useArcadeSession } from '@/hooks/useArcadeSession'
import { useRoomData } from '@/hooks/useRoomData'
import { useViewerId } from '@/hooks/useViewerId'
import {
buildPlayerMetadata,
buildPlayerOwnershipFromRoomData,
} from '@/lib/arcade/player-ownership'
import type { GameMove } from '@/lib/arcade/validation'
import { useGameMode } from '../../../../contexts/GameModeContext'
import { generateGameCards } from '../utils/cardGeneration'
@@ -366,38 +369,14 @@ export function RoomMemoryPairsProvider({ children }: { children: ReactNode }) {
}, [state.pausedGamePhase, state.pausedGameState, hasConfigChanged])
// Helper to build player metadata with correct userId ownership
// This uses roomData.memberPlayers to determine which user owns which player
const buildPlayerMetadata = useCallback(
// Uses centralized utilities from player-ownership module
const buildPlayerMetadataCallback = useCallback(
(playerIds: string[]) => {
const playerMetadata: { [playerId: string]: any } = {}
// Build ownership map from roomData
const ownershipMap = buildPlayerOwnershipFromRoomData(roomData)
// Build reverse mapping: playerId -> userId from roomData.memberPlayers
const playerOwnership = new Map<string, string>()
if (roomData?.memberPlayers) {
for (const [userId, userPlayers] of Object.entries(roomData.memberPlayers)) {
for (const player of userPlayers) {
playerOwnership.set(player.id, userId)
}
}
}
for (const playerId of playerIds) {
const playerData = players.get(playerId)
if (playerData) {
// Get the actual owner userId from roomData, or use local viewerId as fallback
const ownerUserId = playerOwnership.get(playerId) || viewerId || ''
playerMetadata[playerId] = {
id: playerId,
name: playerData.name,
emoji: playerData.emoji,
userId: ownerUserId, // CORRECT: Use actual owner's userId
color: playerData.color,
}
}
}
return playerMetadata
// Build player metadata with correct ownership
return buildPlayerMetadata(playerIds, ownershipMap, players, viewerId)
},
[players, roomData, viewerId]
)
@@ -412,7 +391,7 @@ export function RoomMemoryPairsProvider({ children }: { children: ReactNode }) {
// Capture player metadata from local players map
// This ensures all room members can display player info even if they don't own the players
const playerMetadata = buildPlayerMetadata(activePlayers)
const playerMetadata = buildPlayerMetadataCallback(activePlayers)
// Use current session state configuration (no local state!)
const cards = generateGameCards(state.gameType, state.difficulty)
@@ -427,7 +406,7 @@ export function RoomMemoryPairsProvider({ children }: { children: ReactNode }) {
playerMetadata,
},
})
}, [state.gameType, state.difficulty, activePlayers, buildPlayerMetadata, sendMove])
}, [state.gameType, state.difficulty, activePlayers, buildPlayerMetadataCallback, sendMove])
const flipCard = useCallback(
(cardId: string) => {
@@ -464,7 +443,7 @@ export function RoomMemoryPairsProvider({ children }: { children: ReactNode }) {
}
// Capture player metadata with correct userId ownership
const playerMetadata = buildPlayerMetadata(activePlayers)
const playerMetadata = buildPlayerMetadataCallback(activePlayers)
// Use current session state configuration (no local state!)
const cards = generateGameCards(state.gameType, state.difficulty)
@@ -479,7 +458,7 @@ export function RoomMemoryPairsProvider({ children }: { children: ReactNode }) {
playerMetadata,
},
})
}, [state.gameType, state.difficulty, activePlayers, buildPlayerMetadata, sendMove])
}, [state.gameType, state.difficulty, activePlayers, buildPlayerMetadataCallback, sendMove])
const setGameType = useCallback(
(gameType: typeof state.gameType) => {

View File

@@ -1,5 +1,6 @@
'use client'
import { useEffect, useState } from 'react'
import { useRoomData } from '@/hooks/useRoomData'
import { MemoryPairsGame } from '../matching/components/MemoryPairsGame'
import { RoomMemoryPairsProvider } from '../matching/context/RoomMemoryPairsProvider'
@@ -13,8 +14,31 @@ import { RoomMemoryPairsProvider } from '../matching/context/RoomMemoryPairsProv
* - useArcadeRedirect on /arcade page handles redirecting to active sessions
*/
export default function RoomPage() {
const [mounted, setMounted] = useState(false)
const { roomData, isLoading } = useRoomData()
// Prevent SSR hydration mismatch
useEffect(() => {
setMounted(true)
}, [])
if (!mounted) {
return (
<div
style={{
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
height: '100vh',
fontSize: '18px',
color: '#666',
}}
>
Loading...
</div>
)
}
// Show loading state
if (isLoading) {
return (

View File

@@ -1,6 +1,6 @@
{
"name": "soroban-monorepo",
"version": "2.19.0",
"version": "2.19.1",
"private": true,
"description": "Beautiful Soroban Flashcard Generator - Monorepo",
"workspaces": [