f28256dc60
This commit perfects the visual authenticity of the soroban abacus by implementing proper spacing between beads that matches how a real abacus behaves. Key improvements: 1. Adjacent Bead Spacing System: - Adjacent beads of same type (active-to-active, inactive-to-inactive): 0.5pt spacing (nearly touching) - Transition gaps (active-to-inactive): 8pt spacing (clear visual separation) - Bar-to-bead gaps: 1pt (active) or 8pt (inactive) as appropriate 2. Physical Abacus Authenticity: - Active beads cluster together near the reckoning bar - Inactive beads cluster together away from active beads - Clear visual distinction between active and inactive states - Matches the tactile grouping behavior of real soroban beads 3. Enhanced Visual Impact: - Numbers like 2,3,4: Active earth beads touch each other - Numbers like 6,7,8,9: Both active and inactive groups clearly defined - Number 0: All inactive beads form cohesive groups - Number 5: Clean separation between active heaven and inactive earth Technical Implementation: - New adjacent-spacing parameter (0.5pt) for same-type bead pairs - Updated positioning calculations throughout earth bead logic - Maintained rod bounds calculation compatibility - Preserved all existing gap logic for different-type transitions The result is a much more authentic and visually appealing representation that accurately reflects how beads behave on a physical soroban abacus. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| references | ||
| README.md | ||
| __init__.py | ||
| conftest.py | ||
| test_config.py | ||
| test_generation.py | ||
| test_quiz_functionality.py | ||
| test_visual.py | ||
| test_web_generation.py | ||
README.md
Testing
This directory contains automated tests for the Soroban flashcard generator.
Test Structure
test_config.py- Configuration loading and parsing teststest_generation.py- Core generation logic teststest_visual.py- Visual regression tests using image comparisonconftest.py- Pytest fixtures and configurationreferences/- Reference images for visual regression tests
Running Tests
Quick Start
make pytest-fast # Run unit tests (fast)
make pytest-visual # Run visual regression tests
make pytest # Run all tests
make pytest-cov # Run with coverage report
Direct pytest usage
# All tests
python3 -m pytest tests/ -v
# Skip slow tests
python3 -m pytest tests/ -v -m "not slow"
# Visual tests only
python3 -m pytest tests/test_visual.py -v
# With coverage
python3 -m pytest tests/ -v --cov=src
Visual Testing
The visual tests generate flashcard images and compare them against reference images using perceptual hashing. This catches visual regressions while allowing for minor differences.
Updating References
When you make intentional visual changes, manually delete the old reference images in tests/references/ and run the visual tests. They will automatically create new reference images on first run.
How Visual Tests Work
- Generate test images (PNG format, small size for speed)
- Compare against reference images using
imagehashlibrary - Allow small differences (hash distance < 5) for anti-aliasing variations
- Fail if images differ significantly, indicating a regression
Test Philosophy
- Fast unit tests for logic and configuration
- Visual regression tests for output verification
- Integration tests marked as
@pytest.mark.slow - Meaningful failures with clear error messages
- Easy maintenance when the app evolves
Adding Tests
When adding features:
- Add unit tests in relevant
test_*.pyfile - Add visual tests if output changes
- Update references if visual changes are intentional
- Use appropriate markers (
@pytest.mark.slow, etc.)
CI Integration
Tests are designed to run in CI environments:
- Skip tests requiring typst if not installed
- Use smaller images and lower DPI for speed
- Store reference images in version control
- Clear pass/fail criteria