antialias
/
soroban-abacus-flashcards
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(know-your-world): prevent hint bubble closing when toggling settings 

Use refs for autoHint/autoSpeak/withAccent settings so that changing
them doesn't trigger the hint bubble effect. The bubble now stays open
when toggling settings - changes only affect behavior on next region.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Thomas Hallock 2025-11-26 14:33:36 -06:00
parent cd841ff7dc
commit a67c11ae04
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
apps/web/src/arcade-games/know-your-world/components/MapRenderer.tsx
View File

@ -626,23 +626,31 @@ export function MapRenderer({
// Track previous prompt to detect region changes // Track previous prompt to detect region changes
const prevPromptRef = useRef<string | null>(null) const prevPromptRef = useRef<string | null>(null)
// Store autoHint/autoSpeak in refs so we can read current values without triggering effect
const autoHintRef = useRef(autoHint)
const autoSpeakRef = useRef(autoSpeak)
const withAccentRef = useRef(withAccent)
autoHintRef.current = autoHint
autoSpeakRef.current = autoSpeak
withAccentRef.current = withAccent
// Handle hint bubble and auto-speak when the prompt changes (new region to find) // Handle hint bubble and auto-speak when the prompt changes (new region to find)
// Only runs when currentPrompt changes, not when settings change
useEffect(() => { useEffect(() => {
const isNewRegion = prevPromptRef.current !== null && prevPromptRef.current !== currentPrompt const isNewRegion = prevPromptRef.current !== null && prevPromptRef.current !== currentPrompt
prevPromptRef.current = currentPrompt prevPromptRef.current = currentPrompt
if (autoHint && hasHint) { if (autoHintRef.current && hasHint) {
setShowHintBubble(true) setShowHintBubble(true)
// If region changed and both auto-hint and auto-speak are enabled, speak immediately // If region changed and both auto-hint and auto-speak are enabled, speak immediately
// This handles the case where the bubble was already open // This handles the case where the bubble was already open
if (isNewRegion && autoSpeak && hintText && isSpeechSupported) { if (isNewRegion && autoSpeakRef.current && hintText && isSpeechSupported) {
speakHint(hintText, withAccent) speakHint(hintText, withAccentRef.current)
} }
} else { } else {
setShowHintBubble(false) setShowHintBubble(false)
} }
}, [currentPrompt, autoHint, hasHint, autoSpeak, hintText, isSpeechSupported, speakHint, withAccent]) }, [currentPrompt, hasHint, hintText, isSpeechSupported, speakHint])
// Configuration // Configuration
const MAX_ZOOM = 1000 // Maximum zoom level (for Gibraltar at 0.08px!) const MAX_ZOOM = 1000 // Maximum zoom level (for Gibraltar at 0.08px!)