antialias
/
soroban-abacus-flashcards
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: page indicator not tracking scroll when showing all pages 

The IntersectionObserver was only set up when virtualizing pages,
but the page indicator needs to work in both modes:
- Virtualized mode (worksheet creator): lazy load pages
- Non-virtualized mode (shared worksheets): show all pages

Changed observer setup to always run when totalPages > 1, regardless
of virtualization mode. The visible pages update logic still only
runs when virtualizing to avoid unnecessary state updates.

This fixes the page indicator being stuck on page 1 when initialData
is provided (non-virtualized mode).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Thomas Hallock 2025-11-11 16:24:42 -06:00
parent 8b361f06a4
commit 3d157e32ed
1 changed files with 19 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
apps/web/src/app/create/worksheets/components/WorksheetPreview.tsx
View File

@ -161,18 +161,13 @@ function PreviewContent({ formState, initialData, isScrolling = false }: Workshe
}
})
// Intersection Observer to track visible pages (only when virtualizing)
// Intersection Observer to track current page (works with or without virtualization)
useEffect(() => {
console.log('[PAGE INDICATOR] Observer useEffect triggered - shouldVirtualize:', shouldVirtualize, 'totalPages:', totalPages, 'refsReady:', refsReady)
if (!shouldVirtualize) {
console.log('[PAGE INDICATOR] Skipping observer setup - not virtualizing')
return // Skip virtualization when showing all pages
}
if (totalPages <= 1) {
console.log('[PAGE INDICATOR] Skipping observer setup - only', totalPages, 'page(s)')
return // No need for virtualization with single page
return // No need for page tracking with single page
}
// Wait for refs to be populated
@ -211,24 +206,26 @@ function PreviewContent({ formState, initialData, isScrolling = false }: Workshe
console.log('[PAGE INDICATOR] No visible page (maxRatio = 0), keeping current page')
}
// Update visible pages set
setVisiblePages((prev) => {
const next = new Set(prev)
// Update visible pages set (only when virtualizing)
if (shouldVirtualize) {
setVisiblePages((prev) => {
const next = new Set(prev)
entries.forEach((entry) => {
const pageIndex = Number(entry.target.getAttribute('data-page-index'))
entries.forEach((entry) => {
const pageIndex = Number(entry.target.getAttribute('data-page-index'))
if (entry.isIntersecting) {
// Add visible page
next.add(pageIndex)
// Preload adjacent pages for smooth scrolling
if (pageIndex > 0) next.add(pageIndex - 1)
if (pageIndex < totalPages - 1) next.add(pageIndex + 1)
}
if (entry.isIntersecting) {
// Add visible page
next.add(pageIndex)
// Preload adjacent pages for smooth scrolling
if (pageIndex > 0) next.add(pageIndex - 1)
if (pageIndex < totalPages - 1) next.add(pageIndex + 1)
}
})
return next
})
return next
})
}
},
{
root: null, // Use viewport as root (scrolling happens in parent)