antialias/soroban-abacus-flashcards
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove redundant polling from approval notifications

Browse Source 
Remove polling interval that checked every 5 seconds for approval status.
The socket.io listener provides real-time notifications, making polling
unnecessary and wasteful.

Now relies solely on socket.io for instant approval notifications, which:
- Reduces network traffic
- Simplifies code
- Provides faster response time

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Thomas Hallock
2025-10-14 07:39:49 -05:00
parent 396b6c07c7
commit 0d4f400dca
2 changed files with 6 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
apps/web/src/app/join/[code]/page.tsx
View File

@@ -352,11 +352,11 @@ export default function JoinRoomPage({ params }: { params: { code: string } }) {
}
}
// Socket listener and polling for approval notifications
// Socket listener for approval notifications
useEffect(() => {
if (!approvalRequested || !targetRoomData) return
console.log('[Join Page] Setting up approval listeners for room:', targetRoomData.id)
console.log('[Join Page] Setting up approval listener for room:', targetRoomData.id)
// Socket listener for real-time approval notification
const socket = io({ path: '/api/socket' })
@@ -377,33 +377,9 @@ export default function JoinRoomPage({ params }: { params: { code: string } }) {
console.error('[Join Page] Socket connection error:', error)
})
// Polling fallback - check every 5 seconds
const pollInterval = setInterval(async () => {
try {
console.log('[Join Page] Polling for approval status...')
const res = await fetch(`/api/arcade/rooms/${targetRoomData.id}/join-requests`)
if (res.ok) {
const data = await res.json()
// Check if any request for this user was approved
const approvedRequest = data.requests?.find(
(r: { status: string }) => r.status === 'approved'
)
if (approvedRequest) {
console.log('[Join Page] Request approved via polling! Joining room...')
clearInterval(pollInterval)
socket.disconnect()
handleJoin(targetRoomData.id)
}
}
} catch (err) {
console.error('[Join Page] Failed to poll join requests:', err)
}
}, 5000)
return () => {
console.log('[Join Page] Cleaning up approval listeners')
console.log('[Join Page] Cleaning up approval listener')
socket.disconnect()
clearInterval(pollInterval)
}
}, [approvalRequested, targetRoomData, handleJoin])

37
apps/web/src/components/nav/JoinRoomModal.tsx
View File

@@ -143,11 +143,11 @@ export function JoinRoomModal({ isOpen, onClose, onSuccess }: JoinRoomModalProps
}
}
// Socket listener and polling for approval notifications
// Socket listener for approval notifications
useEffect(() => {
if (!approvalRequested || !roomInfo) return
console.log('[JoinRoomModal] Setting up approval listeners for room:', roomInfo.id)
console.log('[JoinRoomModal] Setting up approval listener for room:', roomInfo.id)
// Socket listener for real-time approval notification
const socket = io({ path: '/api/socket' })
@@ -175,40 +175,9 @@ export function JoinRoomModal({ isOpen, onClose, onSuccess }: JoinRoomModalProps
console.error('[JoinRoomModal] Socket connection error:', error)
})
// Polling fallback - check every 5 seconds
const pollInterval = setInterval(async () => {
try {
console.log('[JoinRoomModal] Polling for approval status...')
const res = await fetch(`/api/arcade/rooms/${roomInfo.id}/join-requests`)
if (res.ok) {
const data = await res.json()
// Check if any request for this user was approved
const approvedRequest = data.requests?.find(
(r: { status: string }) => r.status === 'approved'
)
if (approvedRequest) {
console.log('[JoinRoomModal] Request approved via polling! Joining room...')
clearInterval(pollInterval)
socket.disconnect()
try {
await joinRoom(roomInfo.id)
handleClose()
onSuccess?.()
} catch (err) {
setError(err instanceof Error ? err.message : 'Failed to join room')
setIsLoading(false)
}
}
}
} catch (err) {
console.error('[JoinRoomModal] Failed to poll join requests:', err)
}
}, 5000)
return () => {
console.log('[JoinRoomModal] Cleaning up approval listeners')
console.log('[JoinRoomModal] Cleaning up approval listener')
socket.disconnect()
clearInterval(pollInterval)
}
}, [approvalRequested, roomInfo, joinRoom, handleClose, onSuccess])